-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update payments api for implementation #66
base: payments-api-beta
Are you sure you want to change the base?
Conversation
🌿 Preview your docs: https://chariot-preview-10d923b2-0d6c-46b0-a5b6-8c6b7baf5722.docs.buildwithfern.com |
🌿 Preview your docs: https://chariot-preview-38809a39-d745-4443-a1d7-6527fca3aeb0.docs.buildwithfern.com |
@@ -2418,7 +2418,6 @@ components: | |||
required: | |||
- organization_id | |||
- amount | |||
- payment_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove payment_id as a requirement. This payment id is only relevant if the org creates the payment through the CreatePayments API, but if they choose to process the payments themselves, there is no payment ID to provide
payment: | ||
$ref: "#/components/schemas/Payment" | ||
payment_details: | ||
$ref: "#/components/schemas/PaymentDetails" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed payment details from the create transactions request. Transactions are many-to-one with payments, so it wouldnt make sense to specify payment details in the create transactions route
status: | ||
type: string | ||
description: The status of the transaction | ||
example: "pending" | ||
readOnly: true | ||
enum: | ||
- pending | ||
- submitted | ||
- completed | ||
- canceled | ||
- rejected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we dont allow for updating a transaction, I didnt think it made sense to provide a status (which inherently implies it should be updatable)
🌿 Preview your docs: https://chariot-preview-3e7b9d59-c77f-4048-9596-9b19b9a189cf.docs.buildwithfern.com |
🌿 Preview your docs: https://chariot-preview-cc825c15-f6b4-47a0-a89d-1d1fb4acd76d.docs.buildwithfern.com |
🌿 Preview your docs: https://chariot-preview-7aaa7d0d-0cfd-4fb6-89bd-aec5593f0aab.docs.buildwithfern.com |
🌿 Preview your docs: https://chariot-preview-0bf88c4b-753a-485a-8cab-56107c648b92.docs.buildwithfern.com |
🌿 Preview your docs: https://chariot-preview-b5915d6a-0667-47c5-b860-eb0d2968227b.docs.buildwithfern.com |
🌿 Preview your docs: https://chariot-preview-27f239e4-8975-4d6d-815b-6d0a3d845d61.docs.buildwithfern.com |
🌿 Preview your docs: https://chariot-preview-6d43a2fa-c047-40e7-a3e4-d363c23733c3.docs.buildwithfern.com |
🌿 Preview your docs: https://chariot-preview-09289f24-9c03-46aa-9366-04c7705c5a5c.docs.buildwithfern.com |
No description provided.