Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update payments api for implementation #66

Open
wants to merge 11 commits into
base: payments-api-beta
Choose a base branch
from

Conversation

Neilshweky
Copy link
Contributor

@Neilshweky Neilshweky commented Nov 11, 2024

No description provided.

Copy link

Copy link

@@ -2418,7 +2418,6 @@ components:
required:
- organization_id
- amount
- payment_id
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove payment_id as a requirement. This payment id is only relevant if the org creates the payment through the CreatePayments API, but if they choose to process the payments themselves, there is no payment ID to provide

Comment on lines -2460 to -2463
payment:
$ref: "#/components/schemas/Payment"
payment_details:
$ref: "#/components/schemas/PaymentDetails"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed payment details from the create transactions request. Transactions are many-to-one with payments, so it wouldnt make sense to specify payment details in the create transactions route

Comment on lines -2470 to -2480
status:
type: string
description: The status of the transaction
example: "pending"
readOnly: true
enum:
- pending
- submitted
- completed
- canceled
- rejected
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we dont allow for updating a transaction, I didnt think it made sense to provide a status (which inherently implies it should be updatable)

Copy link

Copy link

Copy link

Copy link

@Neilshweky Neilshweky changed the title remove payments information from transaction apis Update payments api for implementation Nov 20, 2024
Copy link

Copy link

Copy link

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant