Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refafctor CoLang #105

Closed
wants to merge 18 commits into from
Closed

Conversation

wmeijer221
Copy link

No description provided.

@wmeijer221 wmeijer221 closed this Jan 20, 2022
@wmeijer221 wmeijer221 deleted the refac/colang branch January 20, 2022 14:28
@vchrombie
Copy link
Member

Hi @wmeijer221, thanks for your PR, but tbh it is too overwhelming. 😅
It would be great if you can target one specific backend/analyzer and open the PR accordingly so that it is easy for us to review the approach and provide comments on the PR.

WDYT?

Also, we are in the process of integrating a new system for managing the releases. We need the contributors to add changelog files for every pull request (any change to source code) as it is required. You can check the guidelines related to it from https://github.com/chaoss/grimoirelab-toolkit/blob/master/CONTRIBUTING.md#changelog-entries

Please let me know if you have any doubts.

@wmeijer221
Copy link
Author

wmeijer221 commented Jan 21, 2022

Thanks for the remark!

I opened this one by accident, which is why I closed it immediately after.
I'm sorry if you spent a lot of time on this.

The work we did is quite impactful, as it essentially affects all of the backends.
One of my peers opened an issue introducing our changes, so please check that out for context, #104.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants