Fix authentication handling #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add handling of empty SERVERDATA_RESPONSE_VALUE packet before SERVERDATA_AUTH_RESPONSE packet
|
Come to think of it, I was pretty sure I had used this module before I ran into this issue and was surprised it was no longer working - IIRC I used it to communicate with a Rust server that did not have Facepunch's websocket RCON protocol enabled. Unfortunately I no longer have a Rust server running to test with, but Facepunch has deprecated the source RCON protocol and plans to remove it from Rust, so I'm not sure if it's a big enough concern to work around. If anything, Rust would be in violation of the spec, not TF2/Valve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the Valve Developer Wiki, the server will send an empty SERVERDATA_RESPONSE_VALUE packet before the SERVERDATA_AUTH_RESPONSE packet. This code adds handling for this empty packet so authentication succeeds from the module's perspective.
I'm not sure if all games that implement RCON behave this way or not - so we may want to make this an optional feature in the constructor for the object. I can, however, confirm that at least TF2 does work this way, and that my fix allows the library to communicate with my TF2 server.