Skip to content
This repository has been archived by the owner on Sep 25, 2021. It is now read-only.

Implement ExoPlayer #566

Merged
merged 2 commits into from
Nov 17, 2018
Merged

Implement ExoPlayer #566

merged 2 commits into from
Nov 17, 2018

Conversation

alexeyre
Copy link
Contributor

@alexeyre alexeyre commented Oct 6, 2018

  • Add ExoPlayer logic to MultiImageView.java
  • Add option to enable/disable ExoPlayer in MediaSettings (defaults to
    enabled).

Response to #544.

Copy link
Member

@floens floens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I requested two small changed.

Could you also run a formatter over the code? I see some missing spaces.

 - Add ExoPlayer logic to MultiImageView.java
 - Add option to enable/disable ExoPlayer in MediaSettings (defaults to
 enabled).
@alexeyre
Copy link
Contributor Author

alexeyre commented Oct 6, 2018

I implemented your suggestions @floens, I didn't realise my spacings were that bad ¯\_(ツ)_/¯

 - Ran a code formatter to sort out my spacing
 - Refactored hasMediaPlayerAudioTracks(..)
 - Injected UserAgent rather than hardcoding a string
@floens floens merged commit f7c00e7 into chandevel:dev Nov 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants