Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docu review and minor changes #25

Merged
merged 8 commits into from
Aug 26, 2024
Merged

Docu review and minor changes #25

merged 8 commits into from
Aug 26, 2024

Conversation

SamJaarsma
Copy link
Contributor

Added or updated:

  • General explanation on Activity Product, Unit and Service structure.
  • Updated PriceTypes and better explained their purpose when used in price breakdowns
  • Updated and better explained Locations and TransferZones, PickUp and DropOff

@SamJaarsma SamJaarsma requested review from havan and mo-c4t August 22, 2024 15:17
@mo-c4t mo-c4t changed the base branch from c4t to dev August 23, 2024 16:27
havan
havan requested changes Aug 23, 2024
View reviewed changes
Copy link
Member

@havan havan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some comments to be addressed.

There are also some small typos like uppercase/lowercase etc, but I will just update them and push to this branch.

proto/cmp/services/activity/v1alpha/activity_types.proto Outdated Show resolved Hide resolved
proto/cmp/types/v1alpha/price_type.proto Outdated Show resolved Hide resolved
@mo-c4t mo-c4t requested a review from havan August 26, 2024 07:58
@havan havan merged commit 6055374 into dev Aug 26, 2024
4 checks passed
@SamJaarsma SamJaarsma deleted the docu_review branch August 28, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mo-c4t mo-c4t mo-c4t approved these changes

@havan havan havan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamJaarsma @havan @mo-c4t