Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suite #167

Merged
merged 6 commits into from
Feb 21, 2024
Merged

Suite #167

merged 6 commits into from
Feb 21, 2024

Conversation

aeddaqqa
Copy link
Collaborator

@aeddaqqa aeddaqqa commented Feb 21, 2024 •
edited
Loading

Pull Request Description

This pull request introduces several enhancements and fixes aimed at improving the user experience, data presentation, and styling within the application. Here's a breakdown of the changes:

  • Change theme options to dark/light for improved clarity

    • Enhances user experience by switching theme options from day/night to dark/light, providing better visibility and aesthetics.

  • Display 'No Data Available' in C,X & P Chain Tables

    • Adds a feature to display 'No Data Available' in tables for C, X, and P chains when there is no data to show, improving user feedback and clarity.

  • Style: Expand Validator Page to Occupy Remaining Space

    • Enhances the styling of the Validator Page by expanding it to occupy the remaining space, optimizing the layout and improving visual balance.

  • Fix statistics filter

    • Addresses a bug affecting the functionality of the statistics filter by ensuring correct date filtering and data retrieval within the specified time range.

  • Fix date format depending on the selected language

    • Resolves issues with date pickers to ensure smooth functionality across all devices and browsers.
    • Implements changes to display transaction dates and block creation dates in the details view based on the selected language, enhancing localization support.

These changes collectively enhance the application's usability, visual appeal, and internationalization support.

Ayagoumi and others added 6 commits December 29, 2023 16:22
@Ayagoumi
feat: change theme to drk/light instead of day/night (#162)
757dd0b 
* feat: change theme to drk/light instead of day/night

* refactor: add aria-label to XPTransactionList component

* Refactor NavBar Links component
@Ayagoumi
Bug fix (#163)
5fbfcc3 
* fix: show no data available instead of a loading indicator
* refactor: remove unnecessary code
* Style: occupy the rest of the empty page
@aeddaqqa
fix statistics filter
f2169fa
@aeddaqqa
Merge pull request #164 from chain4travel/fix-statistics-filter
43331f7 
Fix statistics filter
@aeddaqqa
fix date format depending on the selected language
5b1cfd1
@aeddaqqa
Merge pull request #166 from chain4travel/date-fix
edf90d0 
fix date format depending on the selected language
@aeddaqqa aeddaqqa requested review from Ayagoumi and mo-c4t February 21, 2024 10:31
Ayagoumi
Ayagoumi approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@Ayagoumi Ayagoumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aeddaqqa aeddaqqa merged commit 7712893 into suite-c4t Feb 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ayagoumi Ayagoumi Ayagoumi approved these changes

@mo-c4t mo-c4t Awaiting requested review from mo-c4t

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeddaqqa @Ayagoumi