Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: dump memory region to file #38

Merged
merged 3 commits into from
Nov 19, 2023
Merged

Conversation

UCSIG
Copy link

@UCSIG UCSIG commented Nov 17, 2023

This adds the option to dump a memory region to a binary file using the dump command. If the file specified in the command already exists, it doesn't overwrite the file, only when the --override option is specified.

I couldn't figure out how to make the --file option an optional argument, thats why I specify the default value as an empty string and check in the command handler if a different value than an empty string is present. Maybe you know how to make the --file option an optional argument instead of a required argument with a default value?

@andelf
Copy link
Contributor

andelf commented Nov 18, 2023

IMHO, --overwrite seems meaningless.
Almost all command line tools overwrite if filenames are provided.

@andelf andelf merged commit cf0a059 into ch32-rs:main Nov 19, 2023
1 check passed
@andelf
Copy link
Contributor

andelf commented Nov 19, 2023

Merged.

  • remove --overwrite
  • rename to -o/--out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants