Skip to content

Commit

Permalink
feat: use swift_library_group for library products (#883)
Browse files Browse the repository at this point in the history
This also changes the names of targets to have a `.rpm` suffix, and
visibility limited to their own repo (you need to depend on the library
product, not the underlying targets).

Signed-off-by: Brentley Jones <[email protected]>
  • Loading branch information
brentleyjones authored Feb 14, 2024
1 parent 16ba0c2 commit 7e31c10
Show file tree
Hide file tree
Showing 67 changed files with 3,780 additions and 5,388 deletions.
4 changes: 2 additions & 2 deletions examples/firebase_example/abtesting/SharedApp/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ swift_library(
# app. This example does not compile without it.
# https://firebase.google.com/docs/ios/setup#add-sdks
# keep
"@swiftpkg_firebase_ios_sdk//:FirebaseRemoteConfig_Swift_FirebaseRemoteConfig",
"@swiftpkg_firebase_ios_sdk//:SwiftPM-PlatformExclude_FirebaseAnalyticsSwiftWrap_FirebaseAnalyticsSwiftTarget", # keep
"@swiftpkg_firebase_ios_sdk//:FirebaseAnalyticsSwift", # keep
"@swiftpkg_firebase_ios_sdk//:FirebaseRemoteConfig",
],
)
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ swift_library(
module_name = "AnalyticsExample",
tags = ["manual"],
visibility = ["//visibility:public"],
deps = ["@swiftpkg_firebase_ios_sdk//:SwiftPM-PlatformExclude_FirebaseAnalyticsWithoutAdIdSupportWrap_FirebaseAnalyticsWithoutAdIdSupportTarget"],
deps = ["@swiftpkg_firebase_ios_sdk//:FirebaseAnalyticsWithoutAdIdSupport"],
)

ios_application(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ swift_library(
visibility = ["//visibility:public"],
# GH202: Incomplete deps are generated.
deps = [
"@swiftpkg_firebase_ios_sdk//:SwiftPM-PlatformExclude_FirebaseAppDistributionWrap_FirebaseAppDistributionTarget",
"@swiftpkg_firebase_ios_sdk//:FirebaseAppDistribution-Beta",
],
)

Expand Down
4 changes: 2 additions & 2 deletions examples/firebase_example/crashlytics/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ swift_library(
tags = ["manual"],
visibility = ["//visibility:public"],
deps = [
"@swiftpkg_firebase_ios_sdk//:Crashlytics_FirebaseCrashlytics",
"@swiftpkg_reachability.swift//:Sources_Reachability",
"@swiftpkg_firebase_ios_sdk//:FirebaseCrashlytics",
"@swiftpkg_reachability.swift//:Reachability",
],
)

Expand Down
Loading

0 comments on commit 7e31c10

Please sign in to comment.