Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add /usr/local/include to include dir for FreeBSD #241

Merged
merged 2 commits into from
Jan 11, 2022

Conversation

murashin
Copy link
Contributor

@murashin murashin commented Aug 6, 2017

Add /usr/local/include dir to include dir that is default dir for the 3rd party software for FreeBSD.
I don't know an appropriate place to put these lines, but these must be placed somewhere for compiling glbinding on FreeBSD.

@scheibel
Copy link
Member

Thanks for the PR. The change looks effective and mergable. However, I think we must research if an addition to the include path suffices or if the linker flags has to be adapted, too. Further, we may want to use another variable or integration point.

I opened a general issue in our cmake-structure project (cginternals/cmake-init#68) where we will handle the port of this PR to our other projects afterwards.

Do you have any comments, @sbusch42?

@scheibel
Copy link
Member

On a second thought, glbinding uses configure and find scripts from cmake or its dependencies to find the third party software. Should the additional search path in usr/local be subject to those find scripts? For which dependency is your PR required for successful compilation?

@murashin
Copy link
Contributor Author

murashin commented Aug 23, 2017

Yes, /usr/local should be added to the search path for the scripts.
All software except for SVN in Prerequisites and Dependencies section are installed under /usr/local as defalt, where SVN is included as svnlite in base system instead of svn.

For filesystem hierarchy, please see hier(7)

  • hier(7) for FreeBSD 11.1-RELEASE
    • FYI, /usr/local is just the default path for 3rd party software. The policy of FreeBSD allows users to change the path for 3rd party software. The path is referenced by PREFIX or LOCALBASE environment variables. See ports(7) for the detail.
  • hier(7) for NetBSD 7.1
    • /usr/pkg is the path for 3rd parth software except for X11-related software that will go into /usr/X11R{6,7}. I don't use NetBSD recent 10 years, so I don't know actual status of the path for X11-related software.
  • hier(7) for OpenBSD 6.1
    • /usr/local is the path for 3rd party software except for X11-related software that will go into /usr/X11R6. I don't use OpenBSD so I also don't know actual status of the path of X11-related software.

If I should write this comment to cginternals/cmake-init#68, especially for hier(7), I'll post same comment to that place.

@scheibel scheibel merged commit 3843860 into cginternals:master Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants