Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clang incomplete return type error #97

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

avagordon01
Copy link
Contributor

before this change, Auto-Vk doesn't compile with clang 18.1.8, with the following error:

In file included from .../avk-test.cc:1:
In file included from .../builddir/_deps/avk-src/include/avk/avk.hpp:223:
.../builddir/_deps/avk-src/include/avk/buffer.hpp:273:4: error: calling 'read_into' with incomplete return type 'avk::command::action_type_command'
  273 |                         read_into(static_cast<void*>(&result), aMetaDataIndex);
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.../builddir/_deps/avk-src/include/avk/buffer.hpp:255:37: note: 'read_into' declared here
  255 |                 avk::command::action_type_command read_into(void* aDataPtr, size_t aMetaDataIndex) const;
      |                                                   ^
.../builddir/_deps/avk-src/include/avk/avk.hpp:215:10: note: forward declaration of 'avk::command::action_type_command'
  215 |                 struct action_type_command;
      |                        ^

there may well be a neater place to put the read function definition than in the main avk.hpp, but I don't know the codebase

@johannesugb johannesugb changed the base branch from master to development July 24, 2024 12:40
@johannesugb johannesugb changed the base branch from development to fix-clang-build July 24, 2024 12:54
@johannesugb johannesugb merged commit f118693 into cg-tuwien:fix-clang-build Jul 24, 2024
1 of 6 checks passed
@johannesugb
Copy link
Member

Thanks for your contribution.

johannesugb added a commit that referenced this pull request Jul 31, 2024
* fix clang incomplete return type error (#97)

* Just added a comment in avk.hpp

---------

Co-authored-by: avagordon01 <[email protected]>
johannesugb added a commit that referenced this pull request Jul 31, 2024
* fix clang incomplete return type error (#97)

* Just added a comment in avk.hpp

* Missing sync hint for device-local buffer sync added

---------

Co-authored-by: avagordon01 <[email protected]>
@avagordon01 avagordon01 deleted the fix-clang-build branch August 2, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants