test #95
Closed
test #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added Vulkan SDK version 1.3.216.0, which is the first that included VMA. * VMA is now directly fetched from GitHub (not a very great solution, but don't know how else to do it) * mkdir before curling vma
* Added commands for indirect drawMeshTasks * Linked implementation to correct function name: draw_mesh_tasks_indirect_count_ext * Trying the workflows with SDK version 1.2.198.1
…er_t&, size_t>& aIndexBufferAndOffset
…to account in buffer_t::fill
…tex buffers as well. Thanks to constexpr there should be no downside to this change whatsoever.
* Added further draw_indirect commands * Bugfix: Post execution handler was not invoked in command_buffer_t::prepare_for_reuse() * Attempt to fix build.yml * trying to fix windows-latest builds
…lg() (#94) * Using std::filesystem to load binary files
* Modified graphics pipeline so that it can now be created with dynamic rendering * Use KHR types to fix build issues with Vulkan 1.2 * Added begin and end rendering commands * Fix bugs in begin_dynamic_rendering() * Apply suggestions from code review Changing local variables naming to lowerCamelCase Co-authored-by: Johannes Unterguggenberger <[email protected]> * Add fixes to issues raised in pr review: - removed dynamic_rendering_attachment - added declare_dynamic(_for) functions to avk::attachment which create dynamic rendering attachments - changed graphics_pipeline_t::renderpass_pointer() back to renderpass_reference() which now returns a reference wrapper * PR proposed fixes (mostly cosmetic) + inital draft of MSAA support (needs to be discussed further) * Modified dynamic rendering attachments to take in subpass_usages and modified the dynamic functionality to conform to these usages * Added View mask to begin dynamic rendering parameters * Trying to fix GitHub workflows * Trying to fix GitHub workflows * Using Invoke-WebRequest instead of curl * Reverted the last change * I have no idea what I'm doing * Moving two vulkan-hpp includes a bit down, namely: #include <vulkan/vulkan_enums.hpp> #include <vulkan/vulkan_structs.hpp> * Testing ["latest", "1.3.216.0", "1.2.198.1"] also in windows-latest * Using vk::ImageLayout::eDepthStencilAttachmentOptimal instead of vk::ImageLayout::eAttachmentOptimal * Disable VMA=ON on Linux with 1.2 SDK --------- Co-authored-by: MatejSakmary <[email protected]>
…ish compatibility with the way of passing renderpass-es (before the merge of dynamic rendering)
…per<const avk::renderpass_t>> aRenderpass also for begin_render_pass_for_framebuffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.