Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

44 create routers for internal and public routes #48

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

jcadam14
Copy link
Contributor

Closes #44

I merged in #46 since it all ties together. So if this is approved first, PR #47 can be closed (since this contains both).

@jcadam14 jcadam14 self-assigned this Nov 19, 2024
@jcadam14 jcadam14 linked an issue Nov 19, 2024 that may be closed by this pull request
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/regtech_mail_api
  api.py
  internal.py
  mailer.py 56, 65-66
  public.py 26
Project Total  

This report was generated by python-coverage-comment-action

Copy link

@lchen-2101 lchen-2101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lchen-2101 lchen-2101 merged commit 1e55993 into main Nov 20, 2024
4 checks passed
@lchen-2101 lchen-2101 deleted the 44-create-routers-for-internal-and-public-routes branch November 20, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create routers for internal and public routes
2 participants