Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with cfqueryparam on more than a single line #621

Merged
merged 12 commits into from
Aug 10, 2024

Conversation

ghedwards
Copy link

If a cfqueryparam is on more than a single line, subsequent @CFLintIgnore lines are incorrect

Fix matching on @CFLintIgnore comments
QueryParamChecker returning a lot of matches, include addition of parameters to exclude code base exclusions such as use of cfloop and common delimiter ( clauseDelim|delim) variables
"QueryParamChecker.allowVariableExpression":"(clauseDelim|delim)",
"QueryParamChecker.allowLineExpression":"<cfloop[^>]*#${variable}#[^>]*>"
@ghedwards
Copy link
Author

Any advice on improvements to the determineIgnoreLines method ?

@ghedwards ghedwards changed the base branch from master to dev April 1, 2019 00:11
Copy link
Collaborator

@denuno denuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I'll do a squash merge of it later, assuming nobody else has comments. Is there a related issue for it?

@denuno denuno merged commit ddd5f2d into cflint:dev Aug 10, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants