CFE-413: set_variable_values_ini for values with equal sign #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickanderson
reviewed
Dec 2, 2020
| select_region => INI_section(escape("$(sectionName)")), | ||
| classes => results("bundle", "set_variable_values_ini_not_$(cindex[$(index)])"), | ||
| if => "edit_$(cindex[$(index)])"; | ||
| "pass2" expression => "pass1"; |
There was a problem hiding this comment.
Ewwwww. Why are you forcing a specific pass restriction?
Presumably, something isn't yet defined or hasn't been completed. Or, not able to select region until the second pass?
There was a problem hiding this comment.
Exactly. If it's on the first pass, if the section doesn't exist yet, it cannot select the region, and fails. It won't reevaluate at the 2nd pass
There was a problem hiding this comment.
Right, but since the promise to insert the section is before the promise to set key values for the region, it should be able to select it during the same pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow equal sign in set_variable_values_ini