-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modern theme and more options #106
base: master
Are you sure you want to change the base?
Conversation
remove python-sphinx, which can not be found by apt-get
@m3lab-zzl I approved the runs, now the CI should run automatically for you from now on. |
You have to adjust the CI to build it, I think you require some new packages in this PR. |
try to install requirements before building
Yes I did add a few I updated CI.yml, waiting for the test result. |
Hi @certik This build process is done, but CI stuck at some SSH key things. |
Thanks! For the ssh keys to work I think one must submit as a branch in the repository itself, I just did it here: #107 ,let's see how the website looks like. |
Great, which theme to use is just a personal choice, no good or bad. I create this PR to make some sort of contribution to thank you for the wonderful and concise notes. Feel free to make your decision. |
Awesome, here is the link of the test page: https://certik.gitlab.io/tpr-test/107/merge/. Thank you so much for improving this. I am still looking for people to help out, I think the notes can be improved and polished. I like the sphinx_book_theme theme the most, but I would like the navigation to be all on the left, like the "Light ReadTheDocs theme". Do you know how to do that? The other thing I still need to check if the URLs of pages have changed or not (ideally not). |
Sadly I am not familiar with the second sidebar of the book theme, I am also seeking a work around to customize TOC and sidebar within this theme, and will update here as soon as I figure out how. |
@certik I spent two days trying to customize the TOC sidebar, but did not succeed. Two major problems:
There may be a final solution, but to save time, currently, I suggest to just settle with the built-in sphinx-book-theme, and get used to the floating TOC shown in the right part, which is the same when we read articles in many websites. |
For issure #105
Tested on my WSL ubuntu, there may be something need further fix.