Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Terra signature doc update #4088

Merged
merged 8 commits into from
Apr 22, 2024
Merged

Terra signature doc update #4088

merged 8 commits into from
Apr 22, 2024

Conversation

MadanKumarGovindaswamy
Copy link
Contributor

@MadanKumarGovindaswamy MadanKumarGovindaswamy commented Apr 16, 2024

Summary

What was changed:

  1. Replaced HTML controls with Terra controls.
  2. Updated Doc

Why it was changed:

HTML buttons does not support a11y.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-XXXX


Thank you for contributing to Terra.
@cerner/terra

@github-actions github-actions bot temporarily deployed to preview-pr-4088 April 16, 2024 08:20 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-4088 April 16, 2024 08:28 Destroyed
@MadanKumarGovindaswamy MadanKumarGovindaswamy marked this pull request as ready for review April 17, 2024 04:55
@MadanKumarGovindaswamy MadanKumarGovindaswamy requested a review from a team as a code owner April 17, 2024 04:55
@github-actions github-actions bot temporarily deployed to preview-pr-4088 April 17, 2024 14:25 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-4088 April 18, 2024 04:54 Destroyed
@sugan2416
Copy link
Collaborator

@MadanKumarGovindaswamy Please update PR description

@github-actions github-actions bot temporarily deployed to preview-pr-4088 April 19, 2024 05:56 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-4088 April 19, 2024 09:18 Destroyed
@rbsree
Copy link

rbsree commented Apr 19, 2024

+1 for Accessibility review for Terra Signature.

  • Document is updated.
  • Added focus to all the interactive elements.

@saket2403 saket2403 merged commit 0eda3a0 into main Apr 22, 2024
22 checks passed
@saket2403 saket2403 deleted the Terra-signature-Doc-update branch April 22, 2024 05:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📦 terra-signature ⭐ Accessibility Reviewed Accessibility has been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants