Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(overmind-devtools): document overmind-devtools for easier local development #617

Merged

Conversation

dpraimeyuu
Copy link
Contributor

@dpraimeyuu dpraimeyuu commented Mar 15, 2024

This tiny PR starts documentation around devtools - main principles behind it, how to contribute and set up it locally.

Thanks to @henri-hulski, I was able to run it and even play with it a bit.

NOTE: I know it might be the wrong package to place such docs, but firstly I wanted to document the knowledge and then later discuss whether it's a right location 😅

Copy link

codesandbox bot commented Mar 15, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link
Member

@henri-hulski henri-hulski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Maybe use "docs" instead of "chore" in the commit message.

@dpraimeyuu
Copy link
Contributor Author

dpraimeyuu commented Mar 15, 2024

@henri-hulski yup, that totally makes sense!

Did you mean PR name or commit name?

I renamed PR name.

@dpraimeyuu dpraimeyuu changed the title chore(overmind-devtools): document overmind-devtools for easier local development docs(overmind-devtools): document overmind-devtools for easier local development Mar 15, 2024
@henri-hulski
Copy link
Member

Actually I mean the commit name as it's used for the release notes.

@henri-hulski
Copy link
Member

henri-hulski commented Mar 15, 2024

You can fix it with

git commit --amend
git push --force

@dpraimeyuu dpraimeyuu force-pushed the chore/document-overmind-devtools-1 branch from f6ddc06 to 914b243 Compare March 17, 2024 20:54
@dpraimeyuu
Copy link
Contributor Author

@henri-hulski commit renamed 😄

@henri-hulski
Copy link
Member

Thanks! I will merge it.

@henri-hulski henri-hulski merged commit 10d5c93 into cerebral:next Mar 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants