Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create logaddexp2 #107

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

create logaddexp2 #107

wants to merge 4 commits into from

Conversation

TK-ES
Copy link
Contributor

@TK-ES TK-ES commented Jun 26, 2024

No description provided.

@MOXIEeee
Copy link
Contributor

MOXIEeee commented Jul 8, 2024

  1. Could you please rename "2nd exponential", eg. “powers of 2” or “exponential function with base 2”.

@TK-ES
Copy link
Contributor Author

TK-ES commented Jul 21, 2024

I modified the name, sorry for not adding a comment

@sauravpandey123
Copy link
Contributor

This is good, it works, but some comments that the previous reviewer did not address.

  1. The name of the operation, Logarithm Add Exponentiations 2, can be made clearer, you can call it "Logaddexp (Base 2)". That is a clearer way of letting the user know that this is done with Base 2.

  2. While the name "exponential function with base 2 (y)" is good, it doesn't actually follow Graphbook Naming Conventions. "The first letter of every word needs to be capitalized" when working with composites. So it can be named "Exponential Function With Base 2 (y)" instead. That follows the conventions we have.

Thank you!

@TK-ES
Copy link
Contributor Author

TK-ES commented Aug 6, 2024

updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants