Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contextutil.safe_while does not sleep between tries if needed to loop infinitely #1995

Merged
merged 3 commits into from
Aug 14, 2024
Merged

contextutil.safe_while does not sleep between tries if needed to loop infinitely #1995

merged 3 commits into from
Aug 14, 2024

Commits on Aug 6, 2024

  1. contextutil: sleep between tries in safe_while again 

    This patch fixes an issue introduced within PR ceph#1816,
that when tries are < 0 (e.g. -1) there is no sleep
occurred between tries.

It also fixes error message, so we repot correct
number of tries we've done now.

Fixes: ee43f87

Signed-off-by: Kyr Shatskyy <[email protected]>
    Kyr Shatskyy committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    7f1968c View commit details
    Browse the repository at this point in the history

  2. suite/util: list_lock() once for get_arch() 

    We only want to try to list_locks() for getting arch by
machine_type when scheduling a suite. Otherwise we've
got into an infinite loop and console log flooded
with useless error messages.

Signed-off-by: Kyr Shatskyy <[email protected]>
    Kyr Shatskyy committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    5836ffe View commit details
    Browse the repository at this point in the history

  3. lock/query: make use of tries for list_locks() 

    The list_locks has been updated with new argument 'tries' in PR#1816,
but by unfortunate mistake hasn't been used yet.

Fixes: 55886ea

Signed-off-by: Kyr Shatskyy <[email protected]>
    Kyr Shatskyy committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    84652ff View commit details
    Browse the repository at this point in the history