Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bunch of downburst fixes #1990

Merged
merged 3 commits into from
Aug 8, 2024
Merged

bunch of downburst fixes #1990

merged 3 commits into from
Aug 8, 2024

Commits on Aug 7, 2024

  1. provision/downburst: ignore "username@" prefix in hostname 

    If downburst gets hostname as an argument which does not have
a username@ prefix (does not include @-symbol) there is an
index out of range error will occur, which we, obviously,
don't want and wish to allow hostnames don't use login names.

Signed-off-by: Kyr Shatskyy <[email protected]>
    Kyr Shatskyy committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    d42c541 View commit details
    Browse the repository at this point in the history

  2. provision/downburst: add PATH to environment 

    Need to passthrough the PATH to downburst environment,
otherwise on some system like macos where mkisofs installed
via homebrew it cannot be found.

Signed-off-by: Kyr Shatskyy <[email protected]>
    Kyr Shatskyy committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    e3a44bb View commit details
    Browse the repository at this point in the history

  3. misc: allow _ssh_keyscan return None again 

    A host may not have any keys, so _ssh_keyscan should return None,
instead of failing with error:

    IndexError: list index out of range

Fixes: dbd55e3

Signed-off-by: Kyr Shatskyy <[email protected]>
    Kyr Shatskyy committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    837a0e1 View commit details
    Browse the repository at this point in the history