Revert "Merge PR #1772 into master" #1773
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 082ae7e, reversing changes made to 31a356e. Signed-off-by: Patrick Donnelly <[email protected]>
|
Also, while octopus is EOL, we are still testing upgrades from it to reef. Can this somehow interfere there (might be a dumb question but this had to be reverted once already so asking just to be sure)? |
You mean quincy I assume?
Ya maybe, let's wait one more release ;) |
Yes, apologies for the braino. |
|
@batrick ping, do we still need this PR? |
It's dead code to remove but needs to stick around for a while until we stop testing upgrade paths from octopus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turtles.
Merge when Octopus is EOL. For reals.
See #1772 and #1624 for history.