.github/workflows/unit_tests.yaml: run in path /teuthology_api #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because teuthology does not monkey patch threads if args have "teuthology_api"[1]. [1] https://github.com/ceph/teuthology/blob/029bda193b1d38b67b279eb5c1037caa8408be24/teuthology/__init__.py#L29 Signed-off-by: Vallari Agrawal <[email protected]>
kamoltat
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because teuthology does not monkey patch threads if args have "teuthology_api": https://github.com/ceph/teuthology/blob/029bda193b1d38b67b279eb5c1037caa8408be24/teuthology/__init__.py#L29
The reason the unit test passed in container is because Dockerfile copies all files in /teuthology_api
so teuthology package sees that in args and doesn't monkey patch threads. And locally, it sees "teuthology-api".
Contribution Guidelines
To sign and test your commits, please refer to Contibution guidelines.
Checklist