setup.cfg & config.py: make sure we load_dotenv() #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VallariAg
previously approved these changes
Feb 5, 2024
Currently, setup.cfg doesn't have python-dotenv as a required dependency so we add that. Moreover, in config.py we didn't really load_dotenv() so we didn't actually load .env into pydantic_settings Signed-off-by: Kamoltat Sirivadhna <[email protected]>
kamoltat
force-pushed
the
wip-ksirivad-fix-dotenv
branch
from
1fb2f3c to
42e12e3
Compare
|
@VallariAg Just needs a thumbs up one more time |
VallariAg
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, setup.cfg doesn't have python-dotenv
as a required dependency so we add that.
Moreover, in config.py we didn't really
load_dotenv() so we didn't actually load
.env into pydantic_settings
Contribution Guidelines
To sign and test your commits, please refer to Contibution guidelines.
Checklist