use config.settings attributes instead of os.getenv #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VallariAg
force-pushed
the
fix-env-vars-usage
branch
from
08ecc9c to
82946dc
Compare
VallariAg
force-pushed
the
fix-env-vars-usage
branch
from
82946dc to
8da90ef
Compare
APISettings() will load all values from .env file as APISettings's attributes. These can be imported in all other modules. ref: https://fastapi.tiangolo.com/advanced/settings/#reading-a-env-file This commit also fixes the issue of missing value of PADDLES_URL in services/helpers.py Signed-off-by: Vallari Agrawal <[email protected]>
VallariAg
force-pushed
the
fix-env-vars-usage
branch
from
8da90ef to
b76f8c5
Compare
zmc
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APISettings() will load all values from .env file as
APISettings's attributes. These can be imported in all
other modules, instead of using load_dotenv in every module.
ref: https://fastapi.tiangolo.com/advanced/settings/#reading-a-env-file
This also fixes the issue of missing value of PADDLES_URL in services/helpers.py