fetch mirror group status #1009
Conversation
sp98
force-pushed
the
mirror-group-status
branch
3 times, most recently
from
7c0317a
to
33de31c
Compare
There was a problem hiding this comment.
The tests are rather cranky. I've tried to point out a few reasons why.
The big item you need to tackle first is to avoid adding new code to an existing file. Start a new file for the new api and the related types, maybe something like mirror_group_status.go ?
| @@ -110,7 +110,8 @@ func GroupImageAdd(groupIoctx *rados.IOContext, groupName string, | |||
| cephIoctx(groupIoctx), | |||
| cGroupName, | |||
| cephIoctx(imageIoctx), | |||
| cImageName) | |||
| cImageName, | |||
| C.uint32_t(0)) | |||
There was a problem hiding this comment.
https://github.com/ceph/ceph/blob/reef/src/include/rbd/librbd.h#L1436
I don't understand these changes to rbd_group_image_add. It only has the four arguments that we're already passing.
| @@ -160,7 +162,8 @@ func GroupImageRemoveByID(groupIoctx *rados.IOContext, groupName string, | |||
| cephIoctx(groupIoctx), | |||
| cGroupName, | |||
| cephIoctx(imageIoctx), | |||
| cid) | |||
| cid, | |||
| C.uint32_t(0)) | |||
There was a problem hiding this comment.
Same. Where are these extra args coming from?
| MirrorGroupStatusStateStopped = MirrorGroupStatusState(C.MIRROR_GROUP_STATUS_STATE_STOPPED) | ||
| ) | ||
|
|
||
| // MirrorImageState represents the mirroring state of a RBD image. |
There was a problem hiding this comment.
Typo/copy-paste mistake is confusing the linter.
| type MirrorGroupStatusState int64 | ||
|
|
||
| const ( | ||
| // MirrorGrouptatusStateUnknown is equivalent to MIRROR_GROUP_STATUS_STATE_UNKNOWN |
There was a problem hiding this comment.
Typo is confusing the linter.
| MirrorGroupStatusStateUnknown = MirrorGroupStatusState(C.MIRROR_GROUP_STATUS_STATE_UNKNOWN) | ||
| // MirrorGroupStatusStateError is equivalent to MIRROR_GROUP_STATUS_STATE_ERROR | ||
| MirrorGroupStatusStateError = MirrorGroupStatusState(C.MIRROR_GROUP_STATUS_STATE_ERROR) | ||
| // MirrorGroupStatusStateStartingReplay is equivalent to MIRROR_GROUP_STATUS_STATE_STARTING_REPLAY | ||
| MirrorGroupStatusStateStartingReplay = MirrorGroupStatusState(C.MIRROR_GROUP_STATUS_STATE_STARTING_REPLAY) | ||
| // MirrorGroupStatusStateReplaying is equivalent to MIRROR_GROUP_STATUS_STATE_REPLAYING | ||
| MirrorGroupStatusStateReplaying = MirrorGroupStatusState(C.MIRROR_GROUP_STATUS_STATE_REPLAYING) | ||
| // MirrorGroupStatusStateStoppingReplay is equivalent to MIRROR_GROUP_STATUS_STATE_STOPPING_REPLAY | ||
| MirrorGroupStatusStateStoppingReplay = MirrorGroupStatusState(C.MIRROR_GROUP_STATUS_STATE_STOPPING_REPLAY) | ||
| // MirrorGroupStatusStateStopped is equivalent to MIRROR_IMAGE_GROUP_STATUS_STATE_STOPPED | ||
| MirrorGroupStatusStateStopped = MirrorGroupStatusState(C.MIRROR_GROUP_STATUS_STATE_STOPPED) |
There was a problem hiding this comment.
Most, if not all (I didn't check), of these flags are unknown on older versions of the code. These should be moved to a new file.
| // const char *group_name | ||
| // mirror_group_global_status_t *mirror_group_status, | ||
| // size_t status_size); | ||
| func GetGlobalMirrorGroupStatus(ioctx *rados.IOContext, groupName string) (GlobalMirrorGroupStatus, error) { |
phlogistonjohn
added
the
API
Signed-off-by: Santosh <[email protected]>
|
closing this in favor of #1010 |
Checklist
//go:build ceph_previewmake api-updateto record new APIsNew or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.
The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with
@Mergifyiorebaseto rebase your PR when github indicates that the PR is out of date with the base branch.