Skip to content

Commit

Permalink
cephfs: add clone progress report in clone status
Browse files Browse the repository at this point in the history
add clone progress report in clone status output

Signed-off-by: Nikhil-Ladha <[email protected]>
  • Loading branch information
Nikhil-Ladha committed Oct 23, 2024
1 parent da1e313 commit ead8776
Show file tree
Hide file tree
Showing 3 changed files with 91 additions and 2 deletions.
12 changes: 10 additions & 2 deletions cephfs/admin/clone.go
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,18 @@ type CloneSource struct {
Snapshot string `json:"snapshot"`
}

// CloneProgressReport contains the progress report of a subvolume clone.
type CloneProgressReport struct {
PercentageCloned string `json:"percentage cloned"`
AmountCloned string `json:"amount cloned"`
FilesCloned string `json:"files cloned"`
}

// CloneStatus reports on the status of a subvolume clone.
type CloneStatus struct {
State CloneState `json:"state"`
Source CloneSource `json:"source"`
State CloneState `json:"state"`
Source CloneSource `json:"source"`
ProgressReport CloneProgressReport `json:"progress_report"`

// failure can be obtained through .GetFailure()
failure *CloneFailure
Expand Down
73 changes: 73 additions & 0 deletions cephfs/admin/clone_progress_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
//go:build ceph_main

package admin

import (
"testing"
"time"

"github.com/stretchr/testify/assert"
)

func TestCloneProgress(t *testing.T) {
fsa := getFSAdmin(t)
volume := "cephfs"
group := "Park"
subname := "Jurrasic"
snapname := "dinodna1"
clonename := "babydino"

err := fsa.CreateSubVolumeGroup(volume, group, nil)
assert.NoError(t, err)
defer func() {
err := fsa.RemoveSubVolumeGroup(volume, group)
assert.NoError(t, err)
}()

svopts := &SubVolumeOptions{
Mode: 0750,
Size: 20 * gibiByte,
}
err = fsa.CreateSubVolume(volume, group, subname, svopts)
assert.NoError(t, err)
defer func() {
err := fsa.RemoveSubVolume(volume, group, subname)
assert.NoError(t, err)
}()

err = fsa.CreateSubVolumeSnapshot(volume, group, subname, snapname)
assert.NoError(t, err)
defer func() {
err := fsa.RemoveSubVolumeSnapshot(volume, group, subname, snapname)
assert.NoError(t, err)
}()

err = fsa.CloneSubVolumeSnapshot(
volume, group, subname, snapname, clonename,
&CloneOptions{TargetGroup: group})
assert.NoError(t, err)
defer func() {
err := fsa.RemoveSubVolume(volume, group, clonename)
assert.NoError(t, err)
}()

for done := false; !done; {
status, err := fsa.CloneStatus(volume, group, clonename)
assert.NoError(t, err)
assert.NotNil(t, status)
switch status.State {
case ClonePending:
case CloneInProgress:
assert.NotNil(t, status.ProgressReport.PercentageCloned)
assert.NotNil(t, status.ProgressReport.AmountCloned)
assert.NotNil(t, status.ProgressReport.FilesCloned)
case CloneComplete:
done = true
case CloneFailed:
t.Fatal("clone failed")
default:
t.Fatalf("invalid status.State: %q", status.State)
}
time.Sleep(5 * time.Millisecond)
}
}
8 changes: 8 additions & 0 deletions cephfs/admin/clone_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ var sampleCloneStatusInProg = []byte(`{
"volume": "cephfs",
"subvolume": "subvol1",
"snapshot": "snap1"
},
"progress_report": {
"percentage cloned": "25%",
"amount cloned": "55/202",
"files cloned": "1/3"
}
}
}`)
Expand Down Expand Up @@ -66,6 +71,9 @@ func TestParseCloneStatus(t *testing.T) {
assert.EqualValues(t, "subvol1", status.Source.SubVolume)
assert.EqualValues(t, "snap1", status.Source.Snapshot)
assert.EqualValues(t, "", status.Source.Group)
assert.EqualValues(t, "25%", status.ProgressReport.PercentageCloned)
assert.EqualValues(t, "55/202", status.ProgressReport.AmountCloned)
assert.EqualValues(t, "1/3", status.ProgressReport.FilesCloned)
}
})
}
Expand Down

0 comments on commit ead8776

Please sign in to comment.