Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: include --nobest while upgrading the devel container packages #5008

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

nixpanic
Copy link
Member

On occasion there are inconsistencies in the CentOS or Ceph RPM
repositories. This can cause dnf update to fail when there are
conflicting versions of a package. By adding the --nobest option,
packages can get upgraded to an older version, but not the latest.

Signed-off-by: Niels de Vos [email protected]

@mergify mergify bot added the component/build Issues and PRs related to compiling Ceph-CSI label Dec 10, 2024
@black-dragon74
Copy link
Member

black-dragon74 commented Dec 10, 2024

Maybe we should take this opportunity to make it like:

RUN dnf -y --nobest update \
      && dnf -y install \
    git \
    make \
    gcc \
    librados-devel \
    libcephfs-devel \
    librbd-devel \
    && dnf clean all \
    && rm -rf /var/cache/yum \
    && true

@nixpanic
Copy link
Member Author

Maybe we should take this opportunity to make it like:

RUN dnf -y --nobest update \
      && dnf -y install \
    git \
    make \
    gcc \
    librados-devel \
    libcephfs-devel \
    librbd-devel \
    && dnf clean all \
    && rm -rf /var/cache/yum \
    && true

The current extra indention is added as the packages are part of the dnf -y install command. All stand-alone commands start with an indention and &&, so I think it is nicely aligned already.

@Rakshith-R
Copy link
Contributor

@Mergifyio queue

Copy link
Contributor

mergify bot commented Dec 10, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at d8a0407

On occasion there are inconsistencies in the CentOS or Ceph RPM
repositories. This can cause `dnf update` to fail when there are
conflicting versions of a package. By adding the `--nobest` option,
packages can get upgraded to an older version, but not the latest.

Signed-off-by: Niels de Vos <[email protected]>
@nixpanic nixpanic force-pushed the build/devel-container/dnf-update branch from f8c8e49 to a95a7e6 Compare December 10, 2024 12:24
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Dec 10, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Dec 10, 2024
@nixpanic nixpanic added the backport-to-release-v3.13 Label to backport from devel to release-v3.13 branch label Dec 10, 2024
@nixpanic nixpanic mentioned this pull request Dec 10, 2024
6 tasks
@mergify mergify bot merged commit d8a0407 into ceph:devel Dec 10, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-release-v3.13 Label to backport from devel to release-v3.13 branch component/build Issues and PRs related to compiling Ceph-CSI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants