Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: test vgs beta api #4974

Draft
wants to merge 3 commits into
base: devel
Choose a base branch
from
Draft

e2e: test vgs beta api #4974

wants to merge 3 commits into from
+1,583 −319

Conversation

Madhu-1
Copy link
Collaborator

@Madhu-1 Madhu-1 commented Nov 25, 2024

testing vgs beta api

@mergify mergify bot added the component/testing Additional test cases or CI work label Nov 25, 2024
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Nov 25, 2024

/test ci/centos/mini-e2e/k8s-1.30

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Nov 25, 2024

/test ci/centos/mini-e2e/k8s-1.31

@Madhu-1 Madhu-1 force-pushed the test-csi-betav1 branch 2 times, most recently from 72823ba to f8487e9 Compare November 25, 2024 10:37
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Nov 25, 2024

/test ci/centos/mini-e2e/k8s-1.31

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Nov 25, 2024

/test ci/centos/mini-e2e/k8s-1.31

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Nov 25, 2024

/test ci/centos/mini-e2e/k8s-1.31

@Madhu-1 Madhu-1 mentioned this pull request Nov 25, 2024
Merged
@nixpanic nixpanic marked this pull request as draft November 25, 2024 12:55
@Madhu-1
e2e: test vgs beta api
c63b4cd 
testing vgs beta api

Signed-off-by: Madhu Rajanna <[email protected]>
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Nov 28, 2024

/test ci/centos/mini-e2e/k8s-1.31

1 similar comment
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Nov 28, 2024

/test ci/centos/mini-e2e/k8s-1.31

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Nov 28, 2024

/test ci/centos/mini-e2e/k8s-1.31

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Nov 28, 2024

/test ci/centos/mini-e2e/k8s-1.31

@iPraveenParihar
Copy link
Contributor

@Madhu-1 We need to update apiVersion in examples?

ceph-csi/examples/cephfs/groupsnapshotclass.yaml

Line 2 in 7731a91

apiVersion: groupsnapshot.storage.k8s.io/v1alpha1

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Nov 28, 2024

@Madhu-1 We need to update apiVersion in examples?

ceph-csi/examples/cephfs/groupsnapshotclass.yaml

Line 2 in 7731a91

apiVersion: groupsnapshot.storage.k8s.io/v1alpha1

required for manual testing, we dont use examples yamls in the e2e test thats why not updated it

@iPraveenParihar
Copy link
Contributor

@Madhu-1 We need to update apiVersion in examples?

ceph-csi/examples/cephfs/groupsnapshotclass.yaml

Line 2 in 7731a91

apiVersion: groupsnapshot.storage.k8s.io/v1alpha1

required for manual testing, we dont use examples yamls in the e2e test thats why not updated it

I think it is used here -> TestVolumeGroupSnapshot() -> testVolumeGroupSnapshot() -> GetVolumeGroupSnapshotClass()

ceph-csi/e2e/volumegroupsnapshot.go

Lines 50 to 55 in 7731a91

return c.volumeGroupSnapshotterBase.testVolumeGroupSnapshot(c)
}
func (c *cephFSVolumeGroupSnapshot) GetVolumeGroupSnapshotClass() (*groupsnapapi.VolumeGroupSnapshotClass, error) {
vgscPath := fmt.Sprintf("%s/%s", cephFSExamplePath, "groupsnapshotclass.yaml")
vgsc := &groupsnapapi.VolumeGroupSnapshotClass{}

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Nov 28, 2024

@Madhu-1 We need to update apiVersion in examples?

ceph-csi/examples/cephfs/groupsnapshotclass.yaml

Line 2 in 7731a91

apiVersion: groupsnapshot.storage.k8s.io/v1alpha1

required for manual testing, we dont use examples yamls in the e2e test thats why not updated it

I think it is used here -> TestVolumeGroupSnapshot() -> testVolumeGroupSnapshot() -> GetVolumeGroupSnapshotClass()

ceph-csi/e2e/volumegroupsnapshot.go

Lines 50 to 55 in 7731a91

return c.volumeGroupSnapshotterBase.testVolumeGroupSnapshot(c)
}
func (c *cephFSVolumeGroupSnapshot) GetVolumeGroupSnapshotClass() (*groupsnapapi.VolumeGroupSnapshotClass, error) {
vgscPath := fmt.Sprintf("%s/%s", cephFSExamplePath, "groupsnapshotclass.yaml")
vgsc := &groupsnapapi.VolumeGroupSnapshotClass{}

only the content will be copied.

@nixpanic nixpanic mentioned this pull request Nov 29, 2024
Merged
@iPraveenParihar
Copy link
Contributor

/test ci/centos/mini-e2e/k8s-1.31

@nixpanic
Copy link
Member

/test ci/centos/mini-e2e/k8s-1.30

@nixpanic
Copy link
Member

/test ci/centos/mini-e2e/k8s-1.31

This job was stared before the change from #4990 was deployed, it may still run into the 120 minute timeout.

@iPraveenParihar
Copy link
Contributor

/retest ci/centos/mini-e2e/k8s-1.31

@nixpanic
Copy link
Member

nixpanic commented Dec 2, 2024

#4990 extended the test time with 30 minutes, from 120 to 150. This is not enough yet, it seems ⌛

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Dec 2, 2024

#4990 extended the test time with 30 minutes, from 120 to 150. This is not enough yet, it seems ⌛

I will adjust/remove pod creation and reduce the number in loop and push the changes again

@Madhu-1
e2e: run vgs for rbd
3f6dacb 
running vgs test for rbd

Signed-off-by: Madhu Rajanna <[email protected]>
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Dec 2, 2024

/test ci/centos/mini-e2e/k8s-1.31

@Madhu-1
ci: increase pvc count
438f3ab 
increase the pvc count

Signed-off-by: Madhu Rajanna <[email protected]>
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Dec 2, 2024

/test ci/centos/mini-e2e/k8s-1.31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component/testing Additional test cases or CI work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Madhu-1 @iPraveenParihar @nixpanic