Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Update cephcsi.go #4096

Merged
merged 1 commit into from
Sep 4, 2023
Merged

doc: Update cephcsi.go #4096

merged 1 commit into from
Sep 4, 2023

Conversation

runzhliu
Copy link
Contributor

@runzhliu runzhliu commented Sep 2, 2023 •
edited by nixpanic
Loading

fix typo

Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Sep 2, 2023

@runzhliu Thanks for the PR can you please refer to https://github.com/ceph/ceph-csi/blob/devel/docs/development-guide.md#code-contribution-workflow for the commit format we follow in cephcsi

@runzhliu runzhliu force-pushed the patch-1 branch 2 times, most recently from 594526b to 7e42912 Compare September 2, 2023 08:49
@runzhliu
Copy link
Contributor Author

runzhliu commented Sep 2, 2023

@runzhliu Thanks for the PR can you please refer to https://github.com/ceph/ceph-csi/blob/devel/docs/development-guide.md#code-contribution-workflow for the commit format we follow in cephcsi

sure ;)

@nixpanic nixpanic changed the title Update cephcsi.go doc: Update cephcsi.go Sep 4, 2023
@mergify mergify bot added ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/docs Issues and PRs related to documentation labels Sep 4, 2023
@nixpanic nixpanic requested a review from a team September 4, 2023 09:44
@nixpanic
Copy link
Member

nixpanic commented Sep 4, 2023

@Mergifyio rebase

@runzhliu @nixpanic
doc: Update README.md and fix typo
5933175 
Unified hump stylek

Signed-off-by: runzhliu <[email protected]>
@mergify
Copy link
Contributor

mergify bot commented Sep 4, 2023

rebase

✅ Branch has been successfully rebased

@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Sep 4, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Sep 4, 2023
@mergify mergify bot merged commit 3be99d6 into ceph:devel Sep 4, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rakshith-R Rakshith-R Rakshith-R approved these changes

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@nixpanic nixpanic nixpanic approved these changes

Assignees
No one assigned
Labels
ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/docs Issues and PRs related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@runzhliu @Madhu-1 @nixpanic @ceph-csi-bot @Rakshith-R