Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use dependabot group feature #4087

Merged
merged 1 commit into from
Aug 29, 2023
Merged

ci: use dependabot group feature #4087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,26 @@
---
version: 2
enable-beta-ecosystems: true
updates:
- package-ecosystem: "gomod"
directory: "/"
schedule:
interval: "weekly"
rebase-strategy: "disabled"
groups:
golang-dependencies:
patterns:
- "github.com/golang*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- "github.com/golang*"
- "github.com/golang**"

question, will this be ** or * in patterns?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will be * as i have seen here

k8s-dependencies:
patterns:
- "k8s.io*"
- "sigs.k8s.io*"
github-dependencies:
patterns:
- "github.com*"
Comment on lines +16 to +20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- "k8s.io*"
- "sigs.k8s.io*"
github-dependencies:
patterns:
- "github.com*"
- "k8s.io*"
- "sigs.k8s.io*"
github-dependencies:
patterns:
- "github.com*"

I think for k8s.io*" and sigs.k8s.io*", singe * make sense since it has only once string to match for example

k8s.io/cloud-provider

only cloud-provider

but for github.com I think it will github.com/** since it has to make a recursive search

github.com/spf13/cobra

/spf13 and /cobra

I guess I'm not confusing things but I have seen /** for recursive search for example branch search

tags:
      - v*
    branches:
      - master
      - release-*
  pull_request:
    branches:
      - master
      - release-*
    paths-ignore:
      - "Documentation/**"

from here https://github.com/rook/rook/blob/master/.github/workflows/canary-integration-test.yml#L4-L15
- "design/**"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @subhamkrai For me this looks to be enough, will revisit this if required in the followup PR.

exclude-patterns:
- "github.com/golang*"
nixpanic marked this conversation as resolved.
Show resolved Hide resolved
- "github.com/container-storage-interface/spec"
labels:
- rebase
commit-message:
Expand Down Expand Up @@ -53,6 +68,19 @@ updates:
schedule:
interval: "weekly"
rebase-strategy: "disabled"
groups:
golang-dependencies:
patterns:
- "github.com/golang*"
k8s-dependencies:
patterns:
- "k8s.io*"
- "sigs.k8s.io*"
github-dependencies:
patterns:
- "github.com*"
exclude-patterns:
- "github.com/golang*"
labels:
- rebase
- ci/skip/e2e
Expand Down