rbd: prevent presetting the ImageID of a new volume

When a new volume is not created yet, the ImageID should not be set to the ID of the snapshot. Signed-off-by: Niels de Vos <[email protected]>
ceph · Nov 27, 2023 · 319aece · 319aece
1 parent 4b1dfeb
commit 319aece
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/internal/rbd/snapshot.go b/internal/rbd/snapshot.go
@@ -107,7 +107,15 @@ func generateVolFromSnap(rbdSnap *rbdSnapshot) *rbdVolume {
 	vol.JournalPool = rbdSnap.JournalPool
 	vol.RadosNamespace = rbdSnap.RadosNamespace
 	vol.RbdImageName = rbdSnap.RbdSnapName
-	vol.ImageID = rbdSnap.ImageID
+
+	// /!\ WARNING /!\
+	//
+	// Do not set the ImageID to the ID of the snapshot, a new image will
+	// be created based on the returned rbdVolume. If the ImageID is set to
+	// the ID of the snapshot, accessing the new image by ID will actually
+	// access the snapshot!
+	// vol.ImageID = rbdSnap.ImageID
+
 	// copyEncryptionConfig cannot be used here because the volume and the
 	// snapshot will have the same volumeID which cases the panic in
 	// copyEncryptionConfig function.