Skip to content

Commit

Permalink
Merge pull request #16 from subhamkrai/add-md-lint
Browse files Browse the repository at this point in the history
 ci: add markdown lint
  • Loading branch information
Madhu-1 authored Oct 16, 2024
2 parents 04cf55c + 3d2fb4e commit 71a3468
Show file tree
Hide file tree
Showing 4 changed files with 41 additions and 13 deletions.
12 changes: 12 additions & 0 deletions .github/workflows/lint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,18 @@ jobs:
- name: govulncheck
uses: golang/govulncheck-action@v1

markdownlint:
name: markdownlint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 1
- uses: DavidAnson/markdownlint-cli2-action@v16
with:
config: .markdownlint.yaml
globs: 'docs/*.md'

shellcheck:
name: Shellcheck
runs-on: ubuntu-latest
Expand Down
16 changes: 16 additions & 0 deletions .markdownlint.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
MD010: false # Hard tabs
MD012: false # Multiple consecutive blank lines
MD013: false # Line length
MD019: false # Multiple spaces after hash on atx style heading
MD021: false # Multiple spaces inside hashes on closed atx style heading
MD022: false # Headings should be surrounded by blank lines
MD024: false # Multiple headings with the same content
MD025: false # Multiple top-level headings in the same document
MD027: false # Multiple spaces after blockquote symbol
MD030: false # Spaces after list markers
MD031: false # Fenced code blocks should be surrounded by blank lines
MD032: false # Lists should be surrounded by blank lines
MD041: false # First line in a file should be a top-level heading
MD043: false # Required heading structure
MD045: false # Images should have alternate text (alt text)
MD053: false # Link and image reference definitions should be needed
2 changes: 1 addition & 1 deletion docs/coding.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Here's a list of some more specific conventions that are often followed in the c

We use the following convention for specifying imports:

```
```text
<import standard library packages>
<import ceph-csi-operator packages>
Expand Down
24 changes: 12 additions & 12 deletions docs/development-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ By contributing to this project you agree to the Developer Certificate of Origin

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages. For example:

```
```text
This is my commit message
More details on what this commit does
Expand All @@ -88,7 +88,7 @@ We use a [DCO bot](https://github.com/apps/dco) to enforce the DCO on each pull

We follow a rough convention for commit messages that is designed to answer two questions: what changed and why? The subject line should feature the what and the body of the commit should describe the why.

```
```text
fix bug in configmap
fix clusterID bug in the configmap where the clusterID is
Expand All @@ -99,7 +99,7 @@ Signed-off-by: Random J Developer <[email protected]>

The format can be described more formally as follows:

```
```text
<subject of the change>
<BLANK LINE>
<paragraph(s) with reason/description>
Expand All @@ -111,19 +111,19 @@ The first line is the subject and should be no longer than 70 characters, the se

Here is a short guide on how to work on a new patch. In this example, we will work on a patch called *hellopatch*:

1. Make sure you Frok's main branch is up to date
1. Make sure you Fork's main branch is up to date

```console
git fetch upstream main:main
git checkout main
git push
```
```console
git fetch upstream main:main
git checkout main
git push
```

2. Create a new branch for your patch:

```console
git checkout -b hellopatch
```
```console
git checkout -b hellopatch
```

Do your work here and commit.

Expand Down

0 comments on commit 71a3468

Please sign in to comment.