Add placement group control to the pool resource. #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really nice :) |
| @@ -13,7 +13,17 @@ def whyrun_supported? | |||
|
|
|||
| action :create do | |||
| if @current_resource.exists | |||
| Chef::Log.info "#{@new_resource} already exists - nothing to do." | |||
| if @current_resource.pg_num == @new_resource.pg_num | |||
There was a problem hiding this comment.
I can be quite dumb... but why not testing @current_resource.pgp_num == @new_resource.pgp_num also? :)
There was a problem hiding this comment.
I felt it was redundant - pg_num should never differ from pgp_num except while changing values. We could test for it just in case something fails though.
There was a problem hiding this comment.
Really as you wish.
Done is better than perfect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows pg_num to be controlled idempotently as part of the pool resource. It will set pg_num and pgp_num if the pg_num property changes on the pool resource.