Move to makeEmpty factory methods for initializing empty edm4hep objects #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That has been removed in AIDASoft/podio#514 and the makeEmpty factory method has been introduced instead.
mirguest
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The public object constructor from an
Obj*is removed with AIDASoft/podio#514 and instead replaced with themakeEmptyfactory method that has the same result. This PR introduces the necessary changes in a backwards compatible manner, so that things should keep working after the podio PR has been merged.If a sort of "clean cut" is desired I can also remove the pre-processor checks and instead bump the required podio version in the CMake configuration to keep things working. In that case we would have to wait until AIDASoft/podio#514 is merged and there is a new podio tag after that.