add TrackHeedSimTool for DC cell simulation #248
Conversation
updated to main
update to main
|
@mirguest could you help to review this PR? Thanks! |
Hi @wenxingfang, is |
|
Hi @mirguest thanks for your nice comments! I have updated the PR, please check it. |
| @@ -87,14 +88,17 @@ Edm4hepWriterAnaElemTool::BeginOfEventAction(const G4Event* anEvent) { | |||
| // reset | |||
| m_track2primary.clear(); | |||
|
|
|||
| auto SimPIonCol = m_SimPrimaryIonizationCol.createAndPut(); | |||
There was a problem hiding this comment.
Hi @wenxingfang , thank you for your update. My last question: do you think that we can also move this part to the TrackHeedSimTool? Because I see you had to const_cast the collection. If you create it in the same tool, then I think you don't need to cast.
There was a problem hiding this comment.
Hi @mirguest , I don't know if there is a way to judge if this G4 simulation step is the beginning of an event in TrackHeedSimTool, because m_SimPrimaryIonizationCol.createAndPut(); should be done at the beginning of an event. Do you have any idea?
|
Hi @mirguest , thanks for your suggestion! I have moved the m_SimPrimaryIonizationCol.createAndPut(); to the TrackHeedSimTool. Could you help to review it? |
|
Hi @mirguest , Do you think if this MR could be merged? |
This PR is for #247