Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAPEX-203 Fix search engine 404 errors #98

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Conversation

allisonrobbins
Copy link
Contributor

Add pages for "nonmappable" techniques so all techniques have a page on site. Will reduce 404 page not found errors when coming from google

Copy link
Contributor

@mehaase mehaase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but left a comment on something that was confusing to keep in mind for future work.

src/mappings_explorer/site_builder.py Outdated Show resolved Hide resolved
@mehaase
Copy link
Contributor

mehaase commented Jul 24, 2024

@allisonrobbins please merge this when you're ready

@allisonrobbins allisonrobbins merged commit 959e3b7 into main Jul 31, 2024
3 checks passed
@allisonrobbins allisonrobbins deleted the MAPEX-203-fix-404 branch July 31, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants