Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAPEX-150 Optimize large files #93

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

mehaase
Copy link
Contributor

@mehaase mehaase commented Mar 19, 2024

If a mappings table has over 500 rows, we now truncate to 500 rows, show a message, and link to the full size file. This improves initial page load, expecially for NIST page which is the first on featured on the home page and is our most popular project.

If a mappings table has over 500 rows, we now truncate to 500 rows, show
a message, and link to the full size file. This improves initial page
load, expecially for NIST page which is the first on featured on the
home page and is our most popular project.
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 22.90%. Comparing base (78f0237) to head (8b64da2).

Files Patch % Lines
src/mappings_explorer/template.py 0.00% 11 Missing ⚠️
src/mappings_explorer/site_builder.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
- Coverage   23.17%   22.90%   -0.28%     
==========================================
  Files          11       11              
  Lines        1506     1524      +18     
==========================================
  Hits          349      349              
- Misses       1157     1175      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mehaase mehaase requested a review from tiffb March 19, 2024 17:19
@mehaase mehaase changed the title MAPEX-190 Optimize large files MAPEX-150 Optimize large files Mar 19, 2024
Copy link
Contributor

@mehaase
Copy link
Contributor Author

mehaase commented Mar 19, 2024

@tiffb can you take a quick look at this? Here's an example, this page was 3MB before and is now 300KB. https://mappingsexplorer.z13.web.core.windows.net/MAPEX-190-optimize-large-files/external/nist/

Screenshot 2024-03-19 at 1 39 10 PM

@tiffb
Copy link
Contributor

tiffb commented Mar 19, 2024

Copy link
Contributor

@tiffb tiffb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azure "All Mappings" table is not loading.

@mehaase
Copy link
Contributor Author

mehaase commented Mar 19, 2024

Azure "All Mappings" table is not loading.

Can you try refreshing? I am seeing it when I click that link.

Copy link
Contributor

@tiffb tiffb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azure page working for me now. Loads up quickly.

@mehaase mehaase merged commit bc7190d into main Mar 19, 2024
3 of 5 checks passed
@mehaase mehaase deleted the MAPEX-190-optimize-large-files branch March 19, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants