-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAPEX-150 Optimize large files #93
Conversation
If a mappings table has over 500 rows, we now truncate to 500 rows, show a message, and link to the full size file. This improves initial page load, expecially for NIST page which is the first on featured on the home page and is our most popular project.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
- Coverage 23.17% 22.90% -0.28%
==========================================
Files 11 11
Lines 1506 1524 +18
==========================================
Hits 349 349
- Misses 1157 1175 +18 ☔ View full report in Codecov by Sentry. |
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-190-optimize-large-files/ |
@tiffb can you take a quick look at this? Here's an example, this page was 3MB before and is now 300KB. https://mappingsexplorer.z13.web.core.windows.net/MAPEX-190-optimize-large-files/external/nist/ |
@mehaase "All Mappings" table is not appearing for Azure (https://mappingsexplorer.z13.web.core.windows.net/MAPEX-190-optimize-large-files/external/azure/): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Azure "All Mappings" table is not loading.
Can you try refreshing? I am seeing it when I click that link. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Azure page working for me now. Loads up quickly.
If a mappings table has over 500 rows, we now truncate to 500 rows, show a message, and link to the full size file. This improves initial page load, expecially for NIST page which is the first on featured on the home page and is our most popular project.