Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapex 113 improve the build mappings explorer build time #85

Merged

Conversation

allisonrobbins
Copy link
Contributor

@allisonrobbins allisonrobbins commented Feb 21, 2024

Save descriptions for NIST and CVE objects to reduce runtime

  • Add files with id/description mappings for NIST and CVE projects
  • Running the build script with --reset-descriptions will delete and replace description files
  • Running build script without the flag will pull descriptions from those description files

Build time has decreased from ~14 minutes to ~5 minutes!

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 85 lines in your changes are missing coverage. Please review.

Comparison is base (4ad3aa5) 24.05% compared to head (11ee7e3) 23.11%.

Files Patch % Lines
src/mappings_explorer/site_builder.py 0.00% 85 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   24.05%   23.11%   -0.95%     
==========================================
  Files          11       11              
  Lines        1426     1484      +58     
==========================================
  Hits          343      343              
- Misses       1083     1141      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@allisonrobbins allisonrobbins marked this pull request as ready for review February 21, 2024 20:56
…mappings-explorer into MAPEX-113-Improve-the-build-mappings-explorer-build-time
Copy link
Contributor

Copy link
Contributor

@mehaase mehaase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow -- that's a fantastic speed up. Thank you @allisonrobbins!

@mehaase mehaase merged commit ea9bfcd into main Feb 22, 2024
3 of 5 checks passed
@mehaase mehaase deleted the MAPEX-113-Improve-the-build-mappings-explorer-build-time branch February 22, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants