-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAPEX-178: fix veris bugs #83
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
- Coverage 23.11% 22.76% -0.36%
==========================================
Files 11 11
Lines 1484 1507 +23
==========================================
Hits 343 343
- Misses 1141 1164 +23 ☔ View full report in Codecov by Sentry. |
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-178_fix_veris_mismatch_counts/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not seeing a perfect match on all counts. For example, value_chain.development
says 26 mappings in the capability groups table, but if I search in the All Mappings table, I only get 23 results.
I clicked through to the "value_chain.development" page and compared the results, and I noticed the 3 results at the end have a capital V: Value_chain.development
, and I guess this is why they are counted differently? We may want to consider finding and fixing these VERIS mappings that have upper case letters in unexpected places.
Here's another example from GCP: cloud_logging should have 1 mapping but shows up as zero in the All Mappings table. On the capability group page I see that 1 mapping but don't see any ATT&CK technique (can't scroll horizontally).
If we need to create separate issues for these, let me know.
…or non mappable capabilities that have non mappable comments
8b40928
to
156be25
Compare
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-178_fix_veris_mismatch_counts/ |
I'm seeing the correct tables & pages - looks good! thank you |
What changed
non_mappable
capability pages built only if the project has non_mappable comments