Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAPEX-178: fix veris bugs #83

Merged
merged 5 commits into from
Feb 27, 2024
Merged

Conversation

emeth1
Copy link
Contributor

@emeth1 emeth1 commented Feb 21, 2024

What changed

  • veris counts on all mappings match
  • all techniques from all domains build correctly
  • capability groups and capabilities with no mappings not in capability groups / capabilities list
  • capabilities with no mappings not added to total mappings count
  • non_mappable capability pages built only if the project has non_mappable comments

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 22.76%. Comparing base (39524b7) to head (156be25).

Files Patch % Lines
src/mappings_explorer/site_builder.py 0.00% 45 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   23.11%   22.76%   -0.36%     
==========================================
  Files          11       11              
  Lines        1484     1507      +23     
==========================================
  Hits          343      343              
- Misses       1141     1164      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Copy link
Contributor

@mehaase mehaase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not seeing a perfect match on all counts. For example, value_chain.development says 26 mappings in the capability groups table, but if I search in the All Mappings table, I only get 23 results.

I clicked through to the "value_chain.development" page and compared the results, and I noticed the 3 results at the end have a capital V: Value_chain.development, and I guess this is why they are counted differently? We may want to consider finding and fixing these VERIS mappings that have upper case letters in unexpected places.

Screenshot 2024-02-21 at 12 05 57 PM

Here's another example from GCP: cloud_logging should have 1 mapping but shows up as zero in the All Mappings table. On the capability group page I see that 1 mapping but don't see any ATT&CK technique (can't scroll horizontally).

Screenshot 2024-02-21 at 12 09 44 PM

If we need to create separate issues for these, let me know.

@emeth1 emeth1 requested review from mehaase and tiffb February 26, 2024 20:31
@tiffb
Copy link
Contributor

tiffb commented Feb 26, 2024

I'm not seeing links in the GCP and AWS non-mappings tables, and therefore I can't find non_mappable capability pages built for these projects which have non_mappable comments.
image
image

@emeth1 emeth1 force-pushed the MAPEX-178_fix_veris_mismatch_counts branch from 8b40928 to 156be25 Compare February 27, 2024 02:03
Copy link
Contributor

@emeth1
Copy link
Contributor Author

emeth1 commented Feb 27, 2024

I'm not seeing links in the GCP and AWS non-mappings tables, and therefore I can't find non_mappable capability pages built for these projects which have non_mappable comments. image image

I don't think it rebuild yet when you checked.
Can you check again now and confirm whether or not you see the correct non mappable table? Thanks.

@tiffb
Copy link
Contributor

tiffb commented Feb 27, 2024

I'm not seeing links in the GCP and AWS non-mappings tables, and therefore I can't find non_mappable capability pages built for these projects which have non_mappable comments.

I don't think it rebuild yet when you checked. Can you check again now and confirm whether or not you see the correct non mappable table? Thanks.

I'm seeing the correct tables & pages - looks good! thank you

@mehaase mehaase merged commit 1e44e4b into main Feb 27, 2024
3 of 5 checks passed
@mehaase mehaase deleted the MAPEX-178_fix_veris_mismatch_counts branch February 27, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants