Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAPEX-183: fix matrix scroll indicator #79

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Conversation

emeth1
Copy link
Contributor

@emeth1 emeth1 commented Feb 16, 2024

What changed

  • matrix scroll right indicator calculated on tactic change, page resize, and on matrix scroll
  • matrix column amount reduces as screen size is decreased

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (001bf5b) 23.77% compared to head (520021a) 23.77%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   23.77%   23.77%           
=======================================
  Files          11       11           
  Lines        1413     1413           
=======================================
  Hits          336      336           
  Misses       1077     1077           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@allisonrobbins allisonrobbins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Publishing the build seems to be failing but I built locally to see the changes

@mehaase mehaase merged commit b793d44 into main Feb 19, 2024
4 of 5 checks passed
@mehaase mehaase deleted the MAPEX-183_matrix_updates branch February 19, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants