New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAPEX-70: Add Export Sanity Checks #19

Merged

mikecarenzo merged 3 commits into main from MAPEX-70_cli_export_sanity_checks

Nov 16, 2023

Contributor

emeth1 commented Nov 15, 2023 •

edited

Loading

Fixes #70

What Changed

mappings file validated on export
sanity checks added
- warning if the mappings file defines groups in metadata that are not used in mappings_objecs
- error if the mappings file contains a group in mappings_objects that is not defined in metadata
- removes extra groups from metadata in exported file
- warning if the mappings file defines mapping types in metadata that are not used in mappings_objecs
- error if the mappings file contains a mapping type in mappings_objects that is not defined in metadata

Known Limitations

none

Eva added 2 commits

November 15, 2023 10:34


          add export sanity checks

341a3da


          fix mistakenly staged changes

6b49773

Contributor

github-actions bot commented Nov 15, 2023

This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-70_cli_export_sanity_checks/

1 similar comment

Contributor

github-actions bot commented Nov 15, 2023

This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-70_cli_export_sanity_checks/

emeth1 requested a review from mikecarenzo

November 15, 2023 15:39

mikecarenzo requested changes

View reviewed changes

src/mapex/cli.py Outdated Show resolved Hide resolved

src/mapex/cli.py Outdated Show resolved Hide resolved

src/mapex/cli.py Outdated Show resolved Hide resolved

src/mapex/cli.py Outdated Show resolved Hide resolved

src/mapex/cli.py Outdated Show resolved Hide resolved

src/mapex/cli.py Outdated Show resolved Hide resolved

src/mapex/cli.py Show resolved Hide resolved

src/mapex/cli.py Show resolved Hide resolved

mikecarenzo changed the title ~~MAPEX 70: Add export sanity checks~~ MAPEX-70: Add Export Sanity Checks


          review changes

b83baf0

Contributor

github-actions bot commented Nov 16, 2023

This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-70_cli_export_sanity_checks/

mikecarenzo approved these changes

View reviewed changes

mikecarenzo merged commit 37324b6 into main

3 checks passed

mikecarenzo deleted the MAPEX-70_cli_export_sanity_checks branch

November 16, 2023 02:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet