Merging develop back in to project-orion #354
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elucchesileon
commented
Nov 27, 2024
| // - Use the last document in each group (according to the value of stix.modified) | ||
| // - Then apply query, skip and limit options | ||
| const aggregation = [ | ||
| { $sort: { 'stix.id': 1, 'stix.modified': 1 } }, |
There was a problem hiding this comment.
The only reason that AssetsRepository has its own retrieveAll function is because of this line. It pulls the last modified document vs. the first modified document in BaseRepository.
Could I convert it to an option instead to avoid so much duplication of code?
elucchesileon
commented
Nov 27, 2024
| includeIdentities: false, | ||
| lastUpdatedBy: options.lastUpdatedBy | ||
| }; | ||
| const relationships = await AttackObjectsService.relationshipsService.retrieveAll(relationshipsOptions); |
There was a problem hiding this comment.
Pointing this out as another place to focus - I moved this from the AttackObjectsRepository since it shouldn't be calling any services. But I'm not sure if I did it correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.