Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search all objects by ATT&CK ID #328

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Search all objects by ATT&CK ID #328

merged 2 commits into from
Dec 13, 2023

Conversation

clemiller
Copy link
Contributor

@clemiller clemiller commented Dec 7, 2023

Added in support of front-end#15

@clemiller clemiller requested a review from ElJocko December 7, 2023 17:11
Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (583f251) 67.45% compared to head (b08ab9a) 67.45%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #328   +/-   ##
========================================
  Coverage    67.45%   67.45%           
========================================
  Files          130      130           
  Lines        17579    17580    +1     
  Branches      2256     2256           
========================================
+ Hits         11858    11859    +1     
  Misses        5713     5713           
  Partials         8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ElJocko ElJocko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Good catch on the missing description in the OpenAPI docs

@ElJocko ElJocko merged commit 1e3f048 into develop Dec 13, 2023
5 checks passed
@ElJocko ElJocko deleted the search-all-by-id branch December 13, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants