Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored techniques service for improved structure and asynchronicity #323

Conversation

vsun757
Copy link

@vsun757 vsun757 commented Nov 2, 2023

No description provided.

@vsun757 vsun757 requested review from ElJocko and seansica November 2, 2023 13:53
Copy link

sonarqubecloud bot commented Nov 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
36.5% 36.5% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Jack Sheriff added 2 commits December 13, 2023 12:29
…-improved-structure-and-asynchronicity

Modified techniques service and tactics service to work correctly together (now that both have the async changes applied).
Handle new duplicateId error message.
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

40.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@ElJocko ElJocko merged commit 6170839 into project-orion Dec 13, 2023
1 of 2 checks passed
@ElJocko
Copy link
Contributor

ElJocko commented Dec 13, 2023

Closes #288

@seansica seansica deleted the 288-refactor-techniques-service-for-improved-structure-and-asynchronicity branch July 22, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants