Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored campaigns service for improved structure and asynchronicity #321

Conversation

vsun757
Copy link

@vsun757 vsun757 commented Oct 26, 2023

No description provided.

@vsun757 vsun757 requested a review from ElJocko October 26, 2023 20:38
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
17.0% 17.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (b937d43) 67.83% compared to head (4d85b81) 68.03%.
Report is 1 commits behind head on project-orion.

Files Patch % Lines
app/controllers/campaigns-controller.js 64.55% 28 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           project-orion     #321      +/-   ##
=================================================
+ Coverage          67.83%   68.03%   +0.19%     
=================================================
  Files                145      146       +1     
  Lines              16799    16441     -358     
  Branches            2075     2013      -62     
=================================================
- Hits               11396    11185     -211     
+ Misses              5395     5248     -147     
  Partials               8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElJocko
Copy link
Contributor

ElJocko commented Dec 20, 2023

Closes #306

@ElJocko ElJocko self-assigned this Dec 20, 2023
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

25.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@ElJocko ElJocko merged commit 20ee4b4 into project-orion Dec 20, 2023
3 of 4 checks passed
@seansica seansica deleted the 306-refactor-campaigns-service-for-improved-structure-and-asynchronicity branch July 22, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants