Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored notes service for improved structure and asynchronicity #316

Conversation

vsun757
Copy link

@vsun757 vsun757 commented Oct 18, 2023

No description provided.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 83 lines in your changes are missing coverage. Please review.

Comparison is base (1125eab) 68.24% compared to head (ab23273) 68.40%.
Report is 1 commits behind head on project-orion.

Files Patch % Lines
app/controllers/notes-controller.js 49.47% 48 Missing ⚠️
app/services/notes-service.js 45.45% 18 Missing ⚠️
app/repository/notes-repository.js 77.33% 17 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           project-orion     #316      +/-   ##
=================================================
+ Coverage          68.24%   68.40%   +0.16%     
=================================================
  Files                146      146              
  Lines              15737    15488     -249     
  Branches            1887     1837      -50     
=================================================
- Hits               10740    10595     -145     
+ Misses              4989     4885     -104     
  Partials               8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Dec 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
38.0% 38.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ElJocko ElJocko self-assigned this Dec 20, 2023
@ElJocko
Copy link
Contributor

ElJocko commented Dec 20, 2023

closes #296

Jack Sheriff added 2 commits January 12, 2024 12:27
…oved-structure-and-asynchronicity

# Conflicts:
#	app/repository/notes-repository.js
Use repository function instead of model.
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

39.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@ElJocko ElJocko merged commit 32490d8 into project-orion Jan 12, 2024
2 of 4 checks passed
@ElJocko ElJocko deleted the 296-refactor-notes-service-for-improved-structure-and-asynchronicity branch January 12, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants