Code

Refactored groups service#313

Code

Merged

seansica merged 37 commits intoproject-orioncenter-for-threat-informed-defense/attack-workbench-rest-api:project-orionfrom 300-refactor-groups-servicecenter-for-threat-informed-defense/attack-workbench-rest-api:300-refactor-groups-serviceCopy head branch name to clipboardNov 7, 2023

+733-1,152

Commits

Commits on Oct 4, 2023

• starting to refactor groups service with service and repository

  vsun757

  committed
  50648ba

• refactoring tests part 1

  vsun757

  committed
  1e07ea3

Commits on Oct 5, 2023

• refactoring groups tests part 2

  vsun757

  committed
  030e9a1

• finished refactoring tests

  vsun757

  committed
  def641b

• finished refactoring tests for queries

  vsun757

  committed
  d771542

• refactored groups controller

  vsun757

  committed
  496b7c6

• fixing some pieces

  vsun757

  committed
  28412f2

• added groups exception

  vsun757

  committed
  a4fbc5d

• added groups exceptions to group service

  vsun757

  committed
  c93c41f

Commits on Oct 6, 2023

• fixing one test error

  vsun757

  committed
  148a27e

• trying to fix errors

  vsun757

  committed
  af6dee3

• all tests pass

  vsun757

  committed
  a2f0969

Commits on Oct 12, 2023

• fixing lint issues

  vsun757

  committed
  f561bd9

Commits on Oct 16, 2023

• making create method static

  vsun757

  committed
  0bc5596

• changing group to this.model

  vsun757

  committed
  51a27b2

Commits on Nov 1, 2023

• Merge branch 'project-orion' of https://github.com/center-for-threat-informed-defense/attack-workbench-rest-api into 300-refactor-groups-service

  seansica

  committed
  c024f60

Commits on Nov 2, 2023

• Remove useless constructor from AssetsService; Pass repository and model at point of instantiation rather than in constructor

  seansica

  committed
  8b9bf30

• Restore missing search match against workspace.attack_id in the $or array in BaseRepository

  seansica

  committed
  5156804

• Remove useless constructor from AssetsRepository; Pass model at point of instantiation rather than in constructor

  seansica

  committed
  ba0ab4b

• Pre-stage new CollectionBundlesRepository

  seansica

  committed
  3ab41cc

• Remove useless constructor from GroupsRepository; Pass model at point of instantiation rather than in constructor

  seansica

  committed
  aef8e31

• Remove useless constructor from MatrixRepository; Pass model at point of instantiation rather than in constructor

  seansica

  committed
  aa7c5f0

• Pre-stage new NotesRepository

  seansica

  committed
  1fe09e9

• Pre-stage new ReferencesRepository

  seansica

  committed
  4cee4be

• Remove useless constructor from TeamsRepository; Pass model at point of instantiation rather than in constructor

  seansica

  committed
  70adbf7

• Remove useless constructor from UserAccountsRepository; Pass model at point of instantiation rather than in constructor

  seansica

  committed
  8fa8d05

• Stop passing Asset model to AssetsService constructor (only need to pass repository)

  seansica

  committed
  7cf5466

• Cleanup GroupsService; only override create with new createGroup wrapper to ensure InvalidTypeError thrown when data.stix.type is not intrusion-set

  seansica

  committed
  b421a13

• Refactor to support backwards compatibility/dual support for callbacks & promises

  seansica

  committed
  f21b3c1

• Remove model from BaseService constructor args

  seansica

  committed
  b4ebdda

• Fix bug in BaseService.create where retrieveAllById was being called instead of retrieveOneById

  seansica

  committed
  6548b6e

• Temporarily cease passing options in AssetsController call to assetsService.retrieveVersionById because it appears to be unused/useless

  seansica

  committed
  d47ef2b

• Add VS Code launch configuration that runs the regression tests to make debugging tests easier

  seansica

  committed
  7985733

• Merge remote-tracking branch 'origin/project-orion' into 300-refactor-groups-service

  seansica

  committed
  7ca786c

• Pass repository to MatrixService via constructor rather than by injecting via global module import

  seansica

  committed
  aacfee4

Commits on Nov 6, 2023

• Add 'type' member variable to BaseService and integrate object STIX type validation check to 'create' method

  seansica

  committed
  a5fc4e7

• Ensure the 'import' option is set to true when callbacks are passed to service.create in the importBundle function within collection-bundles.service

  seansica

  committed
  3fa882a