This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
Develop #60
Merged
Develop #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removes description from Relationship
…-duplicate-mappings Resolve duplicate mappings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what has changed
Fixes parse_mappings.py to prevent duplicate Relationships for the "mitigates" mappings by checking the joined_id. The description is no longer captured as part of the fix to only produce unique entries. Reran make.py to update the content with the new fix.Merges pull request #59 from center-for-threat-informed-defense/bugs/#58duplicate-mappings
Reviewed by @isaisabel
Issues addressed by pull request
Closes Issue #58 Unintended Duplicate Mappings