feat(TreeView): TreeView and TreeItem components #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8a1fadc The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## dev #787 +/- ##
==========================================
- Coverage 86.58% 86.24% -0.35%
==========================================
Files 175 178 +3
Lines 4474 4523 +49
Branches 1519 1532 +13
==========================================
+ Hits 3874 3901 +27
- Misses 296 309 +13
- Partials 304 313 +9
Continue to review full report at Codecov.
|
ecollange
force-pushed
the
feat/tree-view
branch
from
80407a5 to
ad03a07
Compare
silvalaura
reviewed
Jul 6, 2022
There was a problem hiding this comment.
Looking great so far, nice work! 👏
A couple other notes:
- I noticed that the expand buttons don't look clickable (the cursor doesn't change to the pointer). Also, the accessibility check on storybook calls out
Buttons must have discernible textso I think they are just missing the aria label attribute - We try not to commit the package-lock unless something has changed in our packages
packages/react-magma-dom/src/components/TreeView/useTreeView.ts
Outdated
Show resolved
Hide resolved
packages/react-magma-dom/src/components/TreeView/useTreeItem.ts
Outdated
Show resolved
Hide resolved
packages/react-magma-dom/src/components/TreeView/useTreeItem.ts
Outdated
Show resolved
Hide resolved
packages/react-magma-dom/src/components/TreeView/TreeView.stories.tsx
Outdated
Show resolved
Hide resolved
silvalaura
added
the
draft
Closed
chris-cedrone-cengage
approved these changes
Feb 28, 2024
|
Although there are some outstanding TODOs, there will be a followup PR to clean that up. |
silvalaura
added a commit
that referenced
this pull request
Jun 5, 2024
Co-authored-by: Collange, Etienne <[email protected]> Co-authored-by: Laura Silva <[email protected]> Co-authored-by: orion-cengage <[email protected]>
silvalaura
added a commit
that referenced
this pull request
Jun 5, 2024
Co-authored-by: Collange, Etienne <[email protected]> Co-authored-by: Laura Silva <[email protected]> Co-authored-by: orion-cengage <[email protected]>
silvalaura
added a commit
that referenced
this pull request
Aug 15, 2024
Co-authored-by: Collange, Etienne <[email protected]> Co-authored-by: Laura Silva <[email protected]> Co-authored-by: orion-cengage <[email protected]>
silvalaura
added a commit
that referenced
this pull request
Sep 18, 2024
Co-authored-by: Collange, Etienne <[email protected]> Co-authored-by: Laura Silva <[email protected]> Co-authored-by: orion-cengage <[email protected]>
silvalaura
added a commit
that referenced
this pull request
Sep 18, 2024
Co-authored-by: Collange, Etienne <[email protected]> Co-authored-by: Laura Silva <[email protected]> Co-authored-by: orion-cengage <[email protected]>
silvalaura
added a commit
that referenced
this pull request
Sep 18, 2024
Co-authored-by: Collange, Etienne <[email protected]> Co-authored-by: Laura Silva <[email protected]> Co-authored-by: orion-cengage <[email protected]>
silvalaura
added a commit
that referenced
this pull request
Sep 18, 2024
Co-authored-by: Collange, Etienne <[email protected]> Co-authored-by: Laura Silva <[email protected]> Co-authored-by: orion-cengage <[email protected]>
silvalaura
added a commit
that referenced
this pull request
Sep 18, 2024
Co-authored-by: Collange, Etienne <[email protected]> Co-authored-by: Laura Silva <[email protected]> Co-authored-by: orion-cengage <[email protected]>
silvalaura
added a commit
that referenced
this pull request
Sep 18, 2024
Co-authored-by: Collange, Etienne <[email protected]> Co-authored-by: Laura Silva <[email protected]> Co-authored-by: orion-cengage <[email protected]>
silvalaura
added a commit
that referenced
this pull request
Dec 16, 2024
Co-authored-by: Collange, Etienne <[email protected]> Co-authored-by: Laura Silva <[email protected]> Co-authored-by: orion-cengage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #180
What I did
Created a TreeView component.
Screenshots:
Checklist
How to test
Requirements and testing notes found in Notion: https://laura-silva.notion.site/TreeView-1fa9fc9d40654f7dba969a7fbaa492c6