fix(TreeView): Support 'show all' button inside TreeView component #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 14e94c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
silvalaura
requested review from
chris-cedrone-cengage,
moathabuhamad-cengage and
nikitaorliak-cengage
chris-cedrone-cengage
approved these changes
Dec 11, 2024
silvalaura
added a commit
that referenced
this pull request
Dec 16, 2024
silvalaura
added a commit
that referenced
this pull request
Dec 17, 2024
silvalaura
added a commit
that referenced
this pull request
Dec 18, 2024
silvalaura
added a commit
that referenced
this pull request
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: none
What I did
The MAST team reported that with their implementation of a "show all" button, our tree stopped behaving as expected for them after we added support for controlling the tree outside of it (through the tags). I have added functionality through
apiRef.showAll()so that the tree updates as expected.Screenshots:
Checklist
How to test
-- with and without preselected items
-- with and without checkParents / checkChildren
-- tree can be manipulated outside the checkboxes
-- different combinations and sizes of trees
-- with and without disabled items
-- clicking around and selecting items then clicking show all, selecting and deselecting items, collapsing, etc etc